This repository was archived by the owner on Apr 12, 2024. It is now read-only.
chore(docs-app): ensure ToC links contain the path #16610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Refreshes are fine as AngularJS updates the URL correctly. :) It’s just the native interpretation that breaks which affects manual, non-AngularJS navigation like opening the link in a new tab or copying it & pasting. I’d tweak the commit message as it’s not correct now. |
|
Other than that the patch looks good to me. |
Without the path the link is always pointing to the root page, rather than the current page, which means that copying the link address or opening the page in a new tab is broken. Closes angular#16608
petebacondarwin
force-pushed
the
toc-link-fix
branch
from
79b2cb3 to
9307ccf
Compare
|
Landed and cherry picked to 1.6.x and 1.7.x for good measure. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without the path the browser address changes so the hash
fragment is directly on the base url. Then on refresh the
browser navigates to an invalid page.
Closes #16608